Skip to content
This repository was archived by the owner on Jan 28, 2026. It is now read-only.

Reimplementation of GradNotSetToNonePattern from Torchtidy#92

Merged
kit1980 merged 2 commits intometa-pytorch:mainfrom
shivam096:shivam96/gradnone
Feb 7, 2025
Merged

Reimplementation of GradNotSetToNonePattern from Torchtidy#92
kit1980 merged 2 commits intometa-pytorch:mainfrom
shivam096:shivam96/gradnone

Conversation

@shivam096
Copy link
Contributor

Adding rules to check for set_to_none parameter for zero_grad().

By setting set_to_none=True, we can gain speedup

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2025
@shivam096
Copy link
Contributor Author

@kit1980 Can you please review the PR.

@kit1980 kit1980 merged commit 0ee382c into meta-pytorch:main Feb 7, 2025
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants